<html>
<head><meta charset="utf-8"><title>Label cleanup · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html">Label cleanup</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="224083870"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/224083870" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#224083870">(Jan 26 2021 at 18:42)</a>:</h4>
<p>Sorry to start yet another discussion on labels. But this has been floating in my mind since I started triaging.</p>
<p>The current label schema is not very well structured IMO. <code>A-</code> generally represents lint categories. But I think it would be better for it to represent project Areas, similar to <code>rust</code>. I don't know what <code>L-</code> means. It has the lint categories...and smattering of other stuff. <code>rust</code> has <a href="https://rustc-dev-guide.rust-lang.org/contributing.html#issue-triage">documented</a> all their labels and the prefixes. We should do the same.</p>
<p>I propose the following label schema. The prefixes are largely copied from <code>rust</code>.</p>
<ul>
<li><code>A</code>rea of the project<br>
    * <code>A-documentation</code> - Clippy documentation (not lints) or the upcoming Clippy book<br>
    * <code>A-lint</code> - Anything about the actual lints (maybe omit this if it's too broad)<br>
    * <code>A-infra</code> -  CI and whatnot<br>
    * <code>A-website</code> - the Clippy website<br>
    * <code>A-UI</code> - Clippy interface, using and configuring Clippy</li>
<li><code>C</code>ategory of issue: <code>C-bug</code>, <code>C-enhancement</code>, <code>C-tracking-issue</code>, <code>C-question</code>, <code>C-interesting-project</code></li>
<li><code>I</code>mportance of issue: <code>I-crash</code>, <code>I-false-positive</code>, <code>I-false-negative</code>, <code>I-suggestion-causes-error</code>, <code>I-sync-blocker</code></li>
<li><code>L</code>int category: <code>L-complexity</code>, <code>L-correctness</code>, <code>L-guidelines</code>, <code>L-performance</code>, <code>L-restriction</code>, <code>L-style</code>, <code>L-tests</code></li>
</ul>
<p>In the above outline, <code>A-UI</code> and <code>L-restriction</code> are new labels. The rest are renamed, existing labels. I also thought of using <code>K-</code> (Kind of lint) instead of <code>L-</code>, but <code>L-</code> seems more intuitive to me.</p>
<p>Additionally...</p>
<ul>
<li>Rename <code>C-needs-discussion</code> to <code>S-needs-discussion</code> - it's a status, not a category</li>
<li>Remove these:<ul>
<li><code>A-suggestions</code> - seems redundant. Nearly all lints have suggestions. If a suggestion is wrong, it's a bug. Otherwise, these are enhancements.</li>
<li><code>A-unnecessary</code>-  seems too granular, could be merged with <code>A-complexity</code></li>
<li><code>A-musing</code> Not sure what this is. Amusing issues? Same as <code>C-interesting-project</code>? At least add a description.</li>
<li><code>hacktoberfest</code> - do we need to keep this around all year? Redundant with <code>good-first-issue</code>?</li>
<li><code>O-*</code> - probably copied from <code>rust</code> but almost never used</li>
<li><code>rollup</code> - not used</li>
</ul>
</li>
</ul>



<a name="224096524"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/224096524" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#224096524">(Jan 26 2021 at 20:16)</a>:</h4>
<p>Also suggesting <code>A-category</code> - regarding categorization of lints</p>



<a name="224313117"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/224313117" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#224313117">(Jan 28 2021 at 11:24)</a>:</h4>
<p>+1 for changing the labels to match the rust-lang/rust labels.</p>
<ul>
<li><code>rollup</code>: automatically added when a rollup PR is created. </li>
<li><code>hacktoberfest</code>: not really but does is hurt?</li>
<li><code>A-suggestion</code>: Some issues are specifically about suggestions of lints</li>
<li><code>O-*</code>, <code>A-unnecessary</code>,  <code>A-musing</code> agreed</li>
</ul>
<p><code>A-category</code>: For issues about recategorization?</p>



<a name="224364844"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/224364844" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#224364844">(Jan 28 2021 at 17:45)</a>:</h4>
<p>or <code>A-meta</code>?</p>



<a name="224377766"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/224377766" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#224377766">(Jan 28 2021 at 19:14)</a>:</h4>
<p>&lt;del&gt;</p>



<a name="224380049"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/224380049" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#224380049">(Jan 28 2021 at 19:30)</a>:</h4>
<blockquote>
<p><code>A-category</code>: For issues about recategorization?</p>
</blockquote>
<p>Yes. I've seen a couple issues where people think a lint is eligible to move from pedantic for example. Can also include general discussions about lint categories.</p>
<blockquote>
<p>or <code>A-meta</code></p>
</blockquote>
<p>Maybe. I think that could be confused to mean discussions about the project in general. Like currently we have the M- prefix.</p>



<a name="224380505"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/224380505" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#224380505">(Jan 28 2021 at 19:33)</a>:</h4>
<p><code>A-category</code> +1</p>
<p>If one more team member agrees to the suggested changes, I can change the labels.</p>



<a name="224537745"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/224537745" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#224537745">(Jan 29 2021 at 21:42)</a>:</h4>
<p>+1</p>



<a name="225432515"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/225432515" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#225432515">(Feb 06 2021 at 22:09)</a>:</h4>
<p><span class="user-mention" data-user-id="264664">@flip1995</span> Is this on your radar?</p>



<a name="225432565"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/225432565" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#225432565">(Feb 06 2021 at 22:10)</a>:</h4>
<p>Oh totally forgot about that. I will do it now.</p>



<a name="225433969"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/225433969" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#225433969">(Feb 06 2021 at 22:52)</a>:</h4>
<p>I also added <code>L-pedantic</code>, renamed <code>performance</code> to just <code>perf</code> and <code>crash</code> to <code>ICE</code>. I also updated the descriptions of the labels and adapted the color, so it matches the colors of rust-lang/rust. </p>
<p>I haven't removed <code>L-unnecessary</code> yet. Those issue require retriage and reclassify those probably into <code>L-pedantic</code> or <code>L-complexity</code></p>



<a name="225434108"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/225434108" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#225434108">(Feb 06 2021 at 22:56)</a>:</h4>
<p>And finally: updating the triagebot.toml: <a href="https://github.com/rust-lang/rust-clippy/pull/6688">https://github.com/rust-lang/rust-clippy/pull/6688</a></p>



<a name="225438678"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/225438678" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#225438678">(Feb 07 2021 at 01:11)</a>:</h4>
<p>Looks good, thanks! This will help with triage. Maybe L-suggestion should be A-suggestion? <span aria-label="shrug" class="emoji emoji-1f937" role="img" title="shrug">:shrug:</span></p>



<a name="225441549"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/225441549" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#225441549">(Feb 07 2021 at 02:41)</a>:</h4>
<p>still need A-category</p>



<a name="225459699"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/225459699" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#225459699">(Feb 07 2021 at 11:33)</a>:</h4>
<p><span class="user-mention" data-user-id="264664">@flip1995</span>  Is there a reason why you renamed <code>good-first-issue</code> back to <code>good first issue</code> ? It was first renamed to use dashes to enable the usage of <code>@rustbot label ...</code>. Rust doesn't have this issue and just uses <code>E-Easy</code>for that. </p>
<p>I've checked the documentation all references seem to be working correctly except the <code>good-first-issue</code> links <span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="225461618"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/225461618" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#225461618">(Feb 07 2021 at 12:20)</a>:</h4>
<p>I believe because that's a GitHub recommendation? <a href="https://docs.github.com/en/github/building-a-strong-community/encouraging-helpful-contributions-to-your-project-with-labels">https://docs.github.com/en/github/building-a-strong-community/encouraging-helpful-contributions-to-your-project-with-labels</a> Not sure if that causes problems with <code>@rustbot</code></p>



<a name="225461639"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/225461639" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#225461639">(Feb 07 2021 at 12:21)</a>:</h4>
<p>but yeah, if triagebot doesn't support labels with spaces, we should revert it to <code>good-first-issue</code> for now</p>



<a name="225461686"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/225461686" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#225461686">(Feb 07 2021 at 12:22)</a>:</h4>
<p>rustbot has some issues with it. this issue contains some tests with quotes as well <a href="https://github.com/rust-lang/rust-clippy/issues/6467">clippy#6467</a><br>
(The comments that re marked off-topic)</p>



<a name="225461729"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/225461729" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#225461729">(Feb 07 2021 at 12:23)</a>:</h4>
<p>It seems to be GitHubs recommendation. I believe that the dashes still fulfill the original idea of the label <span aria-label="upside down" class="emoji emoji-1f643" role="img" title="upside down">:upside_down:</span></p>



<a name="225462562"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/225462562" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#225462562">(Feb 07 2021 at 12:46)</a>:</h4>
<p>Hm not really. I just gone through the list without much thinking. I can rename it back to the dashes form. Or we can rename it to <code>E-easy</code></p>



<a name="225462627"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Label%20cleanup/near/225462627" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Label.20cleanup.html#225462627">(Feb 07 2021 at 12:48)</a>:</h4>
<p>I like <code>good-first-issue</code> a bit more that <code>E-easy</code> but it isn't that much of a difference. Isn't there a voting bot for this? ^^</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>